Thread (16 messages) 16 messages, 3 authors, 2016-09-08

Re: [PATCH 4/9] hwrng: omap - Use the managed device resource API for registration

From: PrasannaKumar Muralidharan <hidden>
Date: 2016-09-06 16:31:40

quoted hunk ↗ jump to hunk
Use devm_hwrng_register instead of hwrng_register. It avoids the need
to handle unregistration explicitly from the remove function.

Signed-off-by: Romain Perier <redacted>
---
 drivers/char/hw_random/omap-rng.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c
index d47b24d..171c3e8 100644
--- a/drivers/char/hw_random/omap-rng.c
+++ b/drivers/char/hw_random/omap-rng.c
@@ -381,7 +381,7 @@ static int omap_rng_probe(struct platform_device *pdev)
        if (ret)
                goto err_ioremap;

-       ret = hwrng_register(&omap_rng_ops);
+       ret = devm_hwrng_register(dev, &omap_rng_ops);
        if (ret)
                goto err_register;
@@ -402,8 +402,6 @@ static int omap_rng_remove(struct platform_device *pdev)
 {
        struct omap_rng_dev *priv = platform_get_drvdata(pdev);

-       hwrng_unregister(&omap_rng_ops);
-
        priv->pdata->cleanup(priv);

        pm_runtime_put_sync(&pdev->dev);
--
If devm_hwrng_register is used hwrng_unregister will be called after
pm_runtime_disable is called. If RNG device is in use calling
omap_rng_remove may not work properly.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help