Thread (6 messages) 6 messages, 4 authors, 2016-09-13

Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz

From: Bjorn Andersson <hidden>
Date: 2016-09-13 04:00:19
Also in: linux-arm-msm, lkml

On Sat 03 Sep 09:45 PDT 2016, Iaroslav Gridin wrote:
quoted hunk ↗ jump to hunk
Without that, QCE performance is about 2x less.

Signed-off-by: Iaroslav Gridin <redacted>
---
 drivers/crypto/qce/core.c | 18 +++++++++++++++++-
 drivers/crypto/qce/core.h |  2 +-
 2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c
[..]
quoted hunk ↗ jump to hunk
@@ -205,10 +209,20 @@ static int qce_crypto_probe(struct platform_device *pdev)
 	if (IS_ERR(qce->bus))
 		return PTR_ERR(qce->bus);
 
-	ret = clk_prepare_enable(qce->core);
+	ret = clk_prepare_enable(qce->core_src);
 	if (ret)
 		return ret;
 
+	ret = clk_set_rate(qce->core_src, 100000000);
+	if (ret) {
+		dev_warn(qce->dev, "Unable to set QCE core src clk @100Mhz, performance might be degraded\n");
This warning is misleading as you return a failure from probe() when it
happens.
+		goto err_clks_core_src;
+	}
+
[..]
+err_clks_core_src:
+	clk_disable_unprepare(qce->core_src);
 	return ret;
 }
 
Regards,
Bjorn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help