Re: Encryption output buffer description in algif_aead.c file

Am Freitag, 24. Juni 2016, 07:44:49 schrieb Gary R Hook:

Hi Gary,

On 06/24/2016 07:01 AM, Stephan Mueller wrote:

quoted

Am Freitag, 24. Juni 2016, 17:24:02 schrieb Harsh Jain:

Hi Harsh,

quoted

379          * The memory structure for cipher operation has the
following
380          * structure:
381          *      AEAD encryption input:  assoc data || plaintext
382          *      AEAD encryption output: cipherntext || auth tag
383          *      AEAD decryption input:  assoc data || ciphertext ||
auth tag 384          *      AEAD decryption output: plaintext

Right, it returns AAD prepended to the stated output. Do you want to
provide a patch?

If testmgr.c is any model, the caller is expected to populate the
destination
buffer with the AAD. Is my understanding correct? And should this
comment clarify
that point: i.e. the length of the destination is the sum of the lengths
of the
aad + ciphertext + tag?

It may make sense if you would look at libkcapi which handles the input/output 
appropriately. Especially, the kcapi_aead_getdata() function sets up the right 
pointers.

It is correct that the AAD data is taken from the input.

Ciao
Stephan