Re: [PATCH v5 3/9] crypto: add driver-side scomp interface
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2016-06-07 10:22:30
On Thu, Jun 02, 2016 at 01:28:57PM +0100, Giovanni Cabiddu wrote:
quoted hunk ↗ jump to hunk
@@ -96,6 +116,31 @@ struct crypto_acomp *crypto_alloc_acomp(const char *alg_name, u32 type, } EXPORT_SYMBOL_GPL(crypto_alloc_acomp); +struct acomp_req *acomp_request_alloc(struct crypto_acomp *acomp, gfp_t gfp) +{ + struct crypto_tfm *tfm = crypto_acomp_tfm(acomp); + struct acomp_req *req; + + req = __acomp_request_alloc(acomp, gfp); + if (req && (tfm->__crt_alg->cra_type != &crypto_acomp_type)) + return crypto_acomp_scomp_alloc_ctx(req);
The gfp argument is pointless since scomp requires GFP_KERNEL. So please just make it a requirement that acomp_request_alloc always uses GFP_KERNEL. Thanks, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt