Thread (6 messages) 6 messages, 3 authors, 2016-06-06

Re: [PATCH 1/3] char: hw_random: Add Amlogic Meson Hardware Random Generator

From: LABBE Corentin <clabbe.montjoie@gmail.com>
Date: 2016-06-03 09:08:08
Also in: linux-amlogic, linux-arm-kernel, lkml

Hello

I have some minor comments below
+config HW_RANDOM_MESON
+	tristate "Amlogic Meson Random Number Generator support"
+	depends on HW_RANDOM && ARCH_MESON
Perhaps you could change to:
depends on HW_RANDOM
depends on ARCH_MESON || COMPILE_TEST
+
+static int meson_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait)
+{
+	struct meson_rng_data *data =
+			container_of(rng, struct meson_rng_data, rng);
+
+	*(u32 *)buf = readl_relaxed(data->base + RNG_DATA);
+
+	return sizeof(u32);
+}
I think you need a test for max < sizeof(u32)

Regards

LABBE Corentin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help