Re: linux-4.6/drivers/crypto/ux500/hash/hash_core.c: 2 * possible bad size ?

On Mon, May 16, 2016 at 07:13:12PM +0100, David Binderman wrote:

Hello there,

1.

linux-4.6/drivers/crypto/ux500/hash/hash_core.c:784]: (warning) Division by
result of sizeof(). memmove() expects a size in bytes, did you intend to
multiply instead?

Source code is

                memmove(req_ctx->state.buffer,
                    device_data->state.buffer,
                    HASH_BLOCK_SIZE / sizeof(u32));

Maybe better code

                memmove(req_ctx->state.buffer,
                    device_data->state.buffer,
                    HASH_BLOCK_SIZE);

2.

linux-4.6/drivers/crypto/ux500/hash/hash_core.c:835]: (warning) Division by
result of sizeof(). memmove() expects a size in bytes, did you intend to
multiply instead?

Duplicate.

Thanks for noticing these bugs.  This driver hasn't been maintained
since 2012, so unless someone steps up I'm going to just delete it.

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt