Re: [PATCH] crypto: aesni-intel - avoid IPsec re-ordering

On Wed, Jan 20, 2016 at 12:38 AM, Herbert Xu
[off-list ref] wrote:

On Wed, Jan 20, 2016 at 12:31:46AM -0800, Raj Ammanur wrote:

quoted

RAJ: ok. would it also be useful to be able to set the length as a module
load time parameter?

That would be a bad interface.  If we wanted to have an adjustable
limit it needs to be set by the entity that is creating the tfm,
i.e., IPsec.

RAJ: Agreed, but it also has been useful for me for testing/debugging to be
able to specify the size to a KLM, since the other stuff is built into
the kernel.
We atleast got rid of the dup acks, although the out of order pkts still remain.

quoted

RAJ: hmm, thats true, yes.

so, is the below description, that you wrote in one of your email replies,
the solution for which you are going to create a patch?

quoted

So what I'm thinking of is to have the softirq path forcibly regain
control from cryptd where possible.  This is tricky because cryptd
might be in the middle of processing a request.  So that's why I'd
like to disable softirqs while we're processing a request.

Yes.

RAJ: Will wait for the patch to take a look and try it out and test
it.  Sincerely appreciate it.

thanks
--Raj

Cheers,
--
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html