On Tue, 2016-01-19 at 15:57 +0800, Herbert Xu wrote:

On Mon, Jan 18, 2016 at 05:06:05PM +0100, Jean Delvare wrote:

quoted

I don't think it makes sense for a module to have a soft dependency
on itself. This seems quite cyclic by nature and I can't see what
purpose it could serve.

OTOH libcrc32c calls crypto_alloc_shash("crc32c", 0, 0) so it pretty
much assumes that some incarnation of the "crc32c" hash algorithm has
been loaded. Therefore it makes sense to have the soft dependency
there (as crc-t10dif does.)

Signed-off-by: Jean Delvare <redacted>
Cc: Tim Chen <redacted>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>

Well caught.  Patch applied, thanks!

Thanks for the fix.

Tim