Re: [PATCH] crypto: Make CRYPTO_CBC select CRYPTO_ECHAINIV

On Sun, Jan 10, 2016 at 09:16:34PM +0100, Thomas Egerer wrote:

On 01/08/2016 10:48 AM, Herbert Xu wrote:

quoted

Please patch net/ipvX/Kconfig instead as ECHAINIV is only used
by IPsec.

This does not seem right to me. By depending on CRYPTO_CBC in a particular
Kconfig, I would expect the 'default algorithm for CBC' to be transitively
selected with it. It's what CRYPTO_CTR does. There are a couple of places
that use select CRYPTO_CBC but not CRYPTO_ECHAINIV  (ext4, wusbcore, md
to mention a few). Wouldn't these end up unusable too, if CBC-mode doesn't
activate echainiv?

All of those other users should work without echainiv so why would
they need to select it?

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt