Thread (4 messages) 4 messages, 3 authors, 2016-01-02

Re: [PATCH v2] crypto: af_alg - Disallow bind/setkey/... after accept(2)

From: Stephan Mueller <hidden>
Date: 2016-01-02 09:20:23
Also in: lkml

Am Freitag, 1. Januar 2016, 21:12:40 schrieb Stephan Mueller:

Hi Herbert,
Am Mittwoch, 30. Dezember 2015, 11:47:53 schrieb Herbert Xu:

Hi Herbert,
quoted
On Tue, Dec 29, 2015 at 07:36:14PM +0100, Dmitry Vyukov wrote:
quoted
Hello,

On commit 8513342170278468bac126640a5d2d12ffbff106
+ crypto: algif_skcipher - Use new skcipher interface
+ crypto: algif_skcipher - Require setkey before accept(2)
+ crypto: af_alg - Disallow bind/setkey/... after accept(2)
OK there is a silly bug in the last patch.  Here is an updated
version.
With this patch, the AF_ALG interface stops working. I tested the HMAC
operation and I am unable to set the key with the following call:

ret = setsockopt(handle->tfmfd, SOL_ALG, ALG_SET_KEY, key, keylen);

This call returns EBUSY.
Please disregard my email. I did not update my library to the newly requested 
order of performing the setkey before the accept call. After the update of my 
library I can confirm that the modification works for all AF_ALG interfaces.

-- 
Ciao
Stephan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help