On Wed, 2015-11-18 at 13:06 +0800, Herbert Xu wrote:

On Tue, Nov 17, 2015 at 04:30:14PM -0800, Tim Chen wrote:

quoted

On Wed, 2015-11-18 at 08:07 +0800, Herbert Xu wrote:

quoted

On Tue, Nov 17, 2015 at 02:59:29PM -0800, Tim Chen wrote:

quoted

Herbert, would you prefer me to use ablkcipher scatter walk instead,
assuming the overhead of both walk are about the same?

Well since you are going to potentially sleep in the middle of
an operation I'd think ablkcipher is required, no?

We're using blkcipher walk in the implementation. 
As long as we use kmap and instead of kmap_atomic,
it allows us to sleep in the middle of the walk.

What if you were called from an atomic context, such as IPsec?

IPSec will invoke this multi-buffer encrypt with async request.
The work is done in crypto daemon, so it wouldn't be in atomic
context.  But anyway, I'm okay with switching to ablkcipher walk,
as long as it doesn't incur too much more overhead than blkcipher
walk.

Tim