Re: [PATCH 5/8] lib/scatterlist: Add sg_len helper

Am Mittwoch, 9. September 2015, 09:31:00 schrieb Tadeusz Struk:

Hi Tadeusz,

On 09/09/2015 09:27 AM, Stephan Mueller wrote:

quoted

quoted

+int sg_len(struct scatterlist *sg)

unsigned int?

No, because it can return -EINVAL if you call it before you set the key.

I see.

But, shouldn't there be an overflow check? Maybe not here, but in the cases 
where the function is invoked. There is a kmalloc(src_len) without a check for 
negative values.


Ciao
Stephan