Re: [PATCH v3] crypto: omap-aes: Add support for GCM mode
From: Matthijs van Duin <hidden>
Date: 2015-09-20 10:39:10
Also in:
linux-omap, lkml
On 15 September 2015 at 15:28, Lokesh Vutla [off-list ref] wrote:
quoted hunk ↗ jump to hunk
--- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig@@ -293,6 +293,7 @@ config CRYPTO_DEV_OMAP_AES depends on ARCH_OMAP2 || ARCH_OMAP3 || ARCH_OMAP2PLUS select CRYPTO_AES select CRYPTO_BLKCIPHER + select CRYPTO_AEAD
Is it appropriate that this also selects CRYPTO_AEAD on omap2/omap3, even though they do not support GCM?
+#define AES_REG_CTRL_GCM GENMASK(17, 16)
Instead of adding these definitions one bit at a time, can't we get the whole list over with at once? This thing supports: ECB, CBC, and CFB-128 encryption CTR and F8 encryption with 16/32/64/96/128-bit counter XEX (disk encryption) CBC-MAC authentication including the CMAC/OMAC/PMAC subflavors F9 authentication GCM and CCM aead (and raw GHASH, if you happen to have a use for it)