Re: [PATCH 1/2] crypto: skcipher - Add top-level skcipher interface
From: Stephan Mueller <hidden>
Date: 2015-08-21 09:24:18
Am Donnerstag, 20. August 2015, 15:21:45 schrieb Herbert Xu: Hi Herbert,
This patch introduces the crypto skcipher interface which aims to replace both blkcipher and ablkcipher. It's very similar to the existing ablkcipher interface. The main difference is the removal of the givcrypt interface. In order to make the transition easier for blkcipher users, there is a helper SKCIPHER_REQUEST_ON_STACK which can be used to place a request on the stack for synchronous transforms.
If I understand the patch set correctly, a caller uses the skcipher API and the API sets up the synchronous or asynchronous callbacks depending on the chosen cipher implementation. Now, does a caller always need to create an skcipher_request and always need the async logic of providing a callback function and the like, even though a synchronous cipher is chosen? I.e. the caller has no means to use a synchronous cipher operation any more. It looks to me like that, but I would like to confirm. Thank you. Ciao Stephan