Re: [cryptodev:master 119/123] warning: (CRYPTO_DEV_QAT_DH895xCCVF) selects PCI_IOV which has unmet direct dependencies (PCI)

On 08/11/2015 06:57 AM, Herbert Xu wrote:

On Mon, Aug 10, 2015 at 10:44:09AM -0700, Tadeusz Struk wrote:

quoted

quoted

 config CRYPTO_DEV_QAT_DH895xCCVF
 	tristate "Support for Intel(R) DH895xCC Virtual Function"
+	select PCI
 	select PCI_IOV

Wouldn't a dependency on PCI make more sense? Or does this not
work?

Yes, you are right. This is how it is in the PF config.
It also needs to select the qat common code.

---8<---
Fix unmet direct dependencies for QAT_DH895xCCVF

Reported-by: Fengguang Wu <redacted>
Signed-off-by: Tadeusz Struk <redacted>

diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig
index 95a9566..eefccf7 100644
--- a/drivers/crypto/qat/Kconfig
+++ b/drivers/crypto/qat/Kconfig

@@ -24,7 +24,9 @@ config CRYPTO_DEV_QAT_DH895xCC
 
 config CRYPTO_DEV_QAT_DH895xCCVF
 	tristate "Support for Intel(R) DH895xCC Virtual Function"
+	depends on X86 && PCI
 	select PCI_IOV
+	select CRYPTO_DEV_QAT
 
 	help
 	  Support for Intel(R) DH895xcc with Intel(R) QuickAssist Technology