Thread (2 messages) 2 messages, 2 authors, 2015-08-04

crypto: authenc - Add Kconfig dependency on CRYPTO_NULL

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2015-08-04 13:23:23
Subsystem: crypto api, the rest · Maintainers: Herbert Xu, "David S. Miller", Linus Torvalds

On Tue, Aug 04, 2015 at 09:20:03PM +0800, kbuild test robot wrote:
tree:   git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head:   a4198fd4b487afc60810f5a12b994721df220022
commit: 92d95ba91772279b6ef9c6e09661f67abcf27259 [91/97] crypto: authenc - Convert to new AEAD interface
config: i386-randconfig-i0-201531 (attached as .config)
reproduce:
  git checkout 92d95ba91772279b6ef9c6e09661f67abcf27259
  # save the attached .config to linux build tree
  make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   crypto/built-in.o: In function `crypto_authenc_exit_tfm':
quoted
quoted
authenc.c:(.text+0x19141): undefined reference to `crypto_put_default_null_skcipher'
   crypto/built-in.o: In function `crypto_authenc_init_tfm':
quoted
quoted
authenc.c:(.text+0x19198): undefined reference to `crypto_get_default_null_skcipher'
Thanks!

---8<---
CRYPTO_AUTHENC needs to depend on CRYPTO_NULL as authenc uses
null for copying.

Reported-by: Reported-by: Fengguang Wu <redacted>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/crypto/Kconfig b/crypto/Kconfig
index 354bb69..ac7cc62 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -200,6 +200,7 @@ config CRYPTO_AUTHENC
 	select CRYPTO_BLKCIPHER
 	select CRYPTO_MANAGER
 	select CRYPTO_HASH
+	select CRYPTO_NULL
 	help
 	  Authenc: Combined mode wrapper for IPsec.
 	  This is required for IPSec.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help