Thread (20 messages) 20 messages, 2 authors, 2015-08-04

Re: [PATCH 6/8] crypto: qat - Convert to new AEAD interface

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2015-08-02 02:00:33

On Fri, Jul 31, 2015 at 01:39:59PM -0700, Tadeusz Struk wrote:
On 07/30/2015 02:53 AM, Herbert Xu wrote:
quoted
-}, {
+	.init = qat_alg_aead_sha512_init,
+	.exit = qat_alg_aead_exit,
+	.setkey = qat_alg_aead_setkey,
+	.decrypt = qat_alg_aead_dec,
+	.encrypt = qat_alg_aead_enc,
+	.ivsize = AES_BLOCK_SIZE,
+	.maxauthsize = SHA512_DIGEST_SIZE,
Hi Herbert,
crypto_aead_encrypt() and crypto_aead_decrypt() work fine, but crypto_aead_givencrypt(),
which is still supported on the API causes a crash. Should we also disable all the
crypto_aead_giv* calls? I use it in my internal tests.
givencrypt will be removed once all drivers are converted across.
So it must not be used.
Other that that looks ok:
Tested-by: Tadeusz Struk <redacted>
Thanks,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help