Re: [PATCH] crypto: caam - fix rfc4106 encap shared descriptor

On 7/30/2015 4:46 PM, Herbert Xu wrote:

On Thu, Jul 30, 2015 at 04:39:26PM +0300, Horia Geantă wrote:

quoted

The encap shared descriptor was changed to use the new IV convention.
In the process some commands were shifted, making the output length
zero, caam effectively writing garbage in dst.

Thanks.

quoted

While here, update the decap descriptor to execute the "write" commands
before the "read"s (as it previously was).
This makes sure the input fifo is drained before becoming full.

Actually, I deliberately did it that way because there was an errata
which said that doing a skipping load concurrently with a skipping
store may cause a hang.  Is this not the case?

Indeed, there is:
A-005473 - Using SEQ FIFO LOAD SKIP and SEQ FIFO STORE SKIP
simultaneously will cause the DECO to hang.

However, the skip commands are not consecutive, there's a math command
between them (both for encap and decap descriptors).

Horia