Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info

Am Donnerstag, 2. Juli 2015, 15:24:58 schrieb Lokesh Vutla:

Hi Lokesh,

quoted

quoted

+{
+	.cra_name		= "gcm(aes)",
+	.cra_driver_name	= "gcm-aes-omap",
+	.cra_priority		= 100,

Why did you choose the priority 100? The software implementations commonly
use 100. crypto/gcm.c uses the prio of the underlying cipher. In case of
ARM, there seem to be assembler implementations of AES which have the prio
of 200 or 300. So, such software implementation of gcm(aes) would have a
higher precedence than your hw implementation.

Yes, you are right.
Other hw algos in omap-aes also uses priority 100.
Only sw and hw implementations are enabled right now and both are at same
priority. And till now its lucky enough that hw algo gets picked.

Maybe those HW prios should be updated too?

Ciao
Stephan