Re: [PATCH RFC v5 3/4] crypto: rsa: add a new rsa generic implementation

Am Montag, 15. Juni 2015, 18:49:15 schrieb Tadeusz Struk:

Hi Tadeusz,

On 06/15/2015 04:23 PM, Stephan Mueller wrote:

quoted

quoted

+	/* In FIPS mode only allow key size minimum 2K */

quoted

+	if (fips_enabled && (mpi_get_size(key->n) < 256)) {

Considering my previous email, shouldn't that check rather be

if (fips_enabled &&

    ((mpi_get_size(key->n) != 256) || (mpi_get_size(key->n) != 384))

I'm not familiar with the FIPS requirements. I checked the NIST
recommendations witch states that RSA: |n| >= 2048 is acceptable. If FIPS
allows 2K and 3K only then we need to change it.

The reason for exclusive 2k/3k is the CAVS testing: there is only the ability 
to test 2/3k. Longer key sizes are even not allowed as per SP800-131A in favor 
of EC.


-- 
Ciao
Stephan