Re: [PATCH v4 3/4] lib: introduce crc_t10dif_update()

On Tue, 2015-05-05 at 13:22 +0900, Akinobu Mita wrote:

The reason for crypto_shash_import() was I wanted to make
crc_t10dif_update() more generic.  But as far as I can see existing
crct10dif modules (crct10dif-generic and crct10dif-pclmul), we don't
need it (i.e. '*(__u16 *)desc.ctx = crc' instead of crc_t10dif_import)

Do you think it's better to remove crc_t10dif_import call from
crc_t10dif() and crc_t10dif_update() altogether?

Yes, it will be better if we can eliminate crc_t10dif_import call if
we can do a direct assignment.

Tim