Thread (12 messages) 12 messages, 4 authors, 2015-05-04

Re: [PATCH v4 0/6] Seeding DRBG with more entropy

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2015-05-04 06:14:20
Also in: lkml

On Mon, May 04, 2015 at 07:40:12AM +0200, Stephan Mueller wrote:
I am not sure that this approach is helpful, because the suggested approach 
implies using a seeded DRNG and the used get_random_bytes already operates as 
a (not always seeded) DRNG. If we have a blocking interface in the kernel, I 
would recommend to make it identical to /dev/random. With the suggested 
seeding approach for DRBG, we definitely have seed data available to start 
with. Therefore, re-seeding it from another seeded DRNG (i.e. the nonblocking 
pool after it is initialized) may not give us too much extra.
My main concern with your original approach was precisely the
fact that get_random_bytes may be called before the before the
kernel pool is ready.  So Ted's solution solves that perfectly.

Please do what Ted says and we can all move forward.

Thanks!
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help