Re: Nokia N900: omap aes is broken

* Pali Rohár [off-list ref] [150224 09:42]:

On Tuesday 24 February 2015 18:25:12 Tony Lindgren wrote:

quoted

* Pali Rohár [off-list ref] [150218 16:03]:

quoted

--- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c

@@ -3938,8 +3938,9 @@ int __init omap3xxx_hwmod_init(void)

 	if (r < 0)
 	
 		return r;

-	/* Register GP-only hwmod links. */
-	if (h_gp && omap_type() == OMAP2_DEVICE_TYPE_GP) {
+//	/* Register GP-only hwmod links. */
+//	if (h_gp && omap_type() == OMAP2_DEVICE_TYPE_GP) {
+	if (h_gp) {

 		r = omap_hwmod_register_links(h_gp);
 		if (r < 0)
 		
 			return r;

aes hwmod is defined in GP-only hwmod...

Doesn't this depend on the bootloader version of n900 to work?

Regards,

Tony

Ok, it looks like second patch (omap_hwmod_3xxx_data.c) needs 
that aes-enabled bootloader.

OK we need some runtime detection somehow for what's enabled..
 

But first patch (omap3.dtsi) is needed for proper definitions. 
Otherwise omap-aes driver will never work on DT systems.

Yeah that one makes sense to me, I guess you'll do a proper
fix for that one.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html