Re: [PATCH] crypto: aesni - make driver-gcm-aes-aesni helper a proper aead alg

On Sun, Jan 25, 2015 at 08:26:50AM -0800, Tadeusz Struk wrote:

Hi Stephan,
On 01/25/2015 12:58 AM, Stephan Mueller wrote:

quoted

quoted

+static int rfc4106_set_key(struct crypto_aead *parent, const u8 *key,

quoted

+			   unsigned int key_len)
 {
 	struct aesni_rfc4106_gcm_ctx *ctx = aesni_rfc4106_gcm_ctx_get(parent);
 	struct crypto_aead *cryptd_child = cryptd_aead_child(ctx->cryptd_tfm);
+	struct aesni_rfc4106_gcm_ctx *child_ctx =
+		aesni_rfc4106_gcm_ctx_get(cryptd_child);
+	int ret;

+	ret = common_rfc4106_set_key(parent, key, key_len);

Shouldn't that one be crypto_aead_setkey, i.e using the regular crypto API 
instead of internal calls?

No, I don't think so. I think that would create an infinite loop.

So why does it work for ablk_helper but not for aead?

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt