Re: [PATCH] crypto: algif - change algif_skcipher to be asynchronous

On 01/15/2015 06:00 PM, Herbert Xu wrote:

quoted

But then would you like to extend AIO interface to take the IV and

quoted

something that would indicate the encrypt/decrypt operation on
aio_write()? Also as far as I can see AIO doesn't support splice()

Any metadata such as the IV can still go through the existing
sendmsg interface, just as you would do a sendmsg before a sendfile
to set things up.

quoted

quoted

operation for zero copy, which is the main thing here.

The AIO interface itself can accomodate zero-copy.  It's just that
we currently don't have any support for it in the network socket
API.

Hi,
Ok, It looks to me that we *do* have all we need to implement zero copy
and AIO with algif_skcipher. The only thing we need to do is to add
support for it in skcipher_recvmsg(). I think no change is required in
neither skcipher_sendmsg(), skcipher_sendpage(), nor the if_alg interface.
Then to start using the interface asynchronously an application will
need to call aio_read() or lio_listio() instead of read(), but if
someone will use read(), then it will still work in the same
(synchronous) way as it is today.
How does this sound to you, Herbert?
I'll send a v2 shortly.
Thanks,
Tadeusz