Thread (14 messages) 14 messages, 2 authors, 2015-01-26

Re: [PATCH v11 1/2] crypto: AF_ALG: add AEAD support

From: Stephan Mueller <hidden>
Date: 2015-01-26 04:35:12
Also in: linux-api, lkml

Am Montag, 26. Januar 2015, 11:06:31 schrieb Herbert Xu:

Hi Herbert,
On Wed, Jan 21, 2015 at 02:19:17AM +0100, Stephan Mueller wrote:
quoted
+	/*
+	 * Require exactly one IOV block as the AEAD operation is a one shot
+	 * due to the authentication tag.
+	 */
+	if (msg->msg_iter.nr_segs != 1)
+		return -ENOMSG;
Why does limit exist? The fact that you have to do it in one go does
not limit the number of receive IOVs, at least not to one.
It seems I have misunderstood you in the last discussion.

in the last discussion [1] I tried to explain why I did not consider multiple 
IOVs. In the reply to my answer [2] I seem to have understood that the current 
implementation is fine.

So, shall I now implement the multiple IOVs approach outlined in [1]? If yes, 
how many IOVs shall I consider?
Cheers,
[1] http://www.spinics.net/lists/linux-crypto/msg12861.html

[2] http://www.spinics.net/lists/linux-crypto/msg12935.html
-- 
Ciao
Stephan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help