Thread (3 messages) 3 messages, 2 authors, 2014-05-29
STALE4433d

[PATCH] crypto/nx/nx-842: dev_set_drvdata can no longer fail

From: Jean Delvare <hidden>
Date: 2014-05-28 12:02:28

Don't check if dev_set_drvdata() failed, it can't, and it returns void
now.

Signed-off-by: Jean Delvare <redacted>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Robert Jennings <redacted>
Cc: Marcelo Henrique Cerri <redacted>
Cc: Fionnuala Gunter <redacted>
---
I believe this should go through Greg's driver-core tree, as this is
where the rest of the dev_set_drvdata() changes are.

 drivers/crypto/nx/nx-842.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
--- a/drivers/crypto/nx/nx-842.c
+++ b/drivers/crypto/nx/nx-842.c
@@ -1197,12 +1197,7 @@ static int __init nx842_probe(struct vio
 	}
 
 	rcu_read_lock();
-	if (dev_set_drvdata(&viodev->dev, rcu_dereference(devdata))) {
-		rcu_read_unlock();
-		dev_err(&viodev->dev, "failed to set driver data for device\n");
-		ret = -1;
-		goto error;
-	}
+	dev_set_drvdata(&viodev->dev, rcu_dereference(devdata));
 	rcu_read_unlock();
 
 	if (sysfs_create_group(&viodev->dev.kobj, &nx842_attribute_group)) {

-- 
Jean Delvare
SUSE L3 Support
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help