Re: [PATCH 3/3] crypto: Add Allwinner Security System crypto accelerator

On Friday, May 23, 2014 at 12:46:10 PM, Arnd Bergmann wrote:

On Thursday 22 May 2014, Corentin LABBE wrote:

quoted

Le 22/05/2014 17:28, Arnd Bergmann a écrit :

quoted

On Thursday 22 May 2014 17:09:56 LABBE Corentin wrote:

quoted

Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>

My feeling is that this should either be one driver that provides
all five algorithms unconditionally, or five drivers that are each
separate loadable modules and based on top of a common module
that only exports functions but has no active logic itself

I agree for the split.
It was my first intention but I feared to add too many files.
So I propose to split in 6, sunxi-ss-hash.c, sunxi-ss-des.c,
sunxi-ss-aes.c, sunxi-ss-rng.c, sunxi-ss-common.c and sunxi-ss.h Does
can I add a sunxi-ss directory in drivers/crypto ?

Yes, I think a subdirectory would be best.

Full ACK on this one. Use drivers/crypto/sunxi-ss/ .
[...]

Best regards,
Marek Vasut