Thread (1 message) 1 message, 1 author, 2014-05-06

Re: [PATCH] crypto: x86/sha1: fix coverity CID 1195603

From: Pavel Machek <hidden>
Date: 2014-05-06 21:11:33
Also in: lkml

Hi!
Most likely yes but I wanted to keep sha1_ssse3_mod_init consistent
with sha256_ssse3_mod_init/sha512_ssse3_mod_init functions.
quoted
quoted
Reported-by: <redacted>
Signed-off-by: Milos Vyletel <redacted>
---
 arch/x86/crypto/sha1_ssse3_glue.c | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/arch/x86/crypto/sha1_ssse3_glue.c
b/arch/x86/crypto/sha1_ssse3_glue.c
quoted
index 74d16ef..5352196 100644
--- a/arch/x86/crypto/sha1_ssse3_glue.c
+++ b/arch/x86/crypto/sha1_ssse3_glue.c
@@ -235,31 +235,33 @@ static bool __init avx2_usable(void)

 static int __init sha1_ssse3_mod_init(void)
 {
-     char *algo_name;
-
Would simple "algo_name = NULL" be enough to fix this?
Dunno. I'd say that single-line change that is obviously right is
preferable to rewrite inspired by some other function.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help