Thread (14 messages) 14 messages, 5 authors, 2014-03-20
STALE4511d REVIEWED: 1 (0M)

[PATCH 7/9 v7] crypto:s5p-sss: validate iv before memcpy

From: Naveen Krishna Chatradhi <hidden>
Date: 2014-02-17 09:48:10
Also in: linux-samsung-soc, lkml
Subsystem: crypto api, samsung s5p security subsystem (sss) driver, the rest · Maintainers: Herbert Xu, "David S. Miller", Krzysztof Kozlowski, Vladimir Zapolskiy, Linus Torvalds

This patch adds code to validate "iv" buffer before trying to
memcpy the contents

Signed-off-by: Naveen Krishna Chatradhi <redacted>
Reviewed-by: Tomasz Figa <redacted>
CC: David S. Miller <davem@davemloft.net>
CC: Herbert Xu <herbert@gondor.apana.org.au>
CC: Vladimir Zapolskiy <redacted>
TO: <redacted>
CC: <redacted>
---
Changes since v6:
None

 drivers/crypto/s5p-sss.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index fa21db5..7da1da4 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -380,7 +380,8 @@ static void s5p_set_aes(struct s5p_aes_dev *dev,
 {
 	void __iomem *keystart;
 
-	memcpy(dev->aes_ioaddr + SSS_REG_AES_IV_DATA(0), iv, 0x10);
+	if (iv)
+		memcpy(dev->aes_ioaddr + SSS_REG_AES_IV_DATA(0), iv, 0x10);
 
 	if (keylen == AES_KEYSIZE_256)
 		keystart = dev->aes_ioaddr + SSS_REG_AES_KEY_DATA(0);
-- 
1.7.9.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help