Thread (2 messages) 2 messages, 2 authors, 2014-02-09

Re: Fix ccp_run_passthru_cmd dma variable assignments

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2014-02-09 09:20:59
Also in: lkml

On Fri, Jan 24, 2014 at 02:17:12PM -0600, Tom Lendacky wrote:
On 01/24/2014 12:39 PM, Dave Jones wrote:
quoted
There are some suspicious looking lines of code in the new ccp driver, including
one that assigns a variable to itself, and another that overwrites a previous assignment.

This may have been a cut-and-paste error where 'src' was forgotten to be changed to 'dst'.
I have no hardware to test this, so this is untested.
Yes, this was a cut-and-paste error that was not discovered with my tests. I've
updated my testcases and tested/verified this fix.

Herbert, this should probably go through the cryptodev-2.6 tree right?

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
Applied to cryptodev.  Thanks.
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help