Re: [PATCH 03/18] asymmetric keys: separate the length checking of octet string from RSA_I2OSP
From: joeyli <jlee@suse.com>
Date: 2013-08-26 10:26:56
Also in:
linux-efi, linux-pm
於 日，2013-08-25 於 18:01 +0200，Pavel Machek 提到：
On Thu 2013-08-22 19:01:42, Lee, Chun-Yi wrote:quoted
Due to RSA_I2OSP is not only used by signature verification path but also used in signature generation path. So, separate the length checking of octet string because it's not for generate 0x00 0x01 leading string when used in signature generation. Reviewed-by: Jiri Kosina <redacted> Signed-off-by: Lee, Chun-Yi <jlee@suse.com>quoted
+static int RSA_I2OSP(MPI x, size_t xLen, u8 **_X) +{ + unsigned x_size; + unsigned X_size; + u8 *X = NULL;Is this kernel code or entry into obfuscated C code contest? This is not funny. Pavel
The small "x" is the input integer that will transfer to big "X" that is a octet sting. Sorry for I direct give variable name to match with spec, maybe I need use big_X or.... Do you have good suggest for the naming? Thanks a lot! Joey Lee