Re: Tcrypt hmac(crc32) test can work only on Blackfin

On 11/21/2012 12:29 PM, Zhang, Sonic wrote:

Is there a policy that the CRC test vector
in testmgr.h should support all CRC drivers?
If so, I am fine to drop this test vector.

Question for Herbert...
But the problem I see is that it confuses people, it simply
returns fail everytime (except Blackfin platform).

My mail originates from bug report "tcrypt tests started failing",
and it was not obvious why (for people not familiar with tcrypt
internals, they just tried all test modes available).

quoted

IMHO either it should provide crc32c (as do generic, sparc or x86 hw drivers) or
the block size for crc32c should be 4... (and test vector is wrong then)

I can set the default polynomials to that of crc32c for blackfin crc32 driver.
But, it should not be limited to crc32c.

Sure, my question was just about test vector, hw driver support
for something more is of course good thing.

But it would be nice to have "crc32c" directly supported/accelerated as well.

Thanks,
Milan