RE: [PATCH 3/4] fsl-dma: support attribute of DMA_MEMORY when async_tx enabled

-----Original Message-----
From: Dan Williams [mailto:dan.j.williams@intel.com]
Sent: Wednesday, July 11, 2012 3:39 AM
To: Liu Qiang-B32616
Cc: linux-crypto@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Li Yang-
R58472; Phillips Kim-R1AAHA; Vinod Koul
Subject: Re: [PATCH 3/4] fsl-dma: support attribute of DMA_MEMORY when
async_tx enabled

On Mon, Jul 9, 2012 at 10:59 PM, Qiang Liu [off-list ref]
wrote:

quoted

- delete attribute of DMA_INTERRUPT because fsl-dma doesn't support
this function, exception will be thrown if talitos is used to compute

xor

quoted

at the same time;
- change the release process of dma descriptor for avoiding exception

when

quoted

enable config NET_DMA, release dma descriptor from 1st to last second,

the

quoted

last descriptor which is reserved in current descriptor register may

not be

quoted

completed, race condition will be raised if free current descriptor;
- use spin_lock_bh to instead of spin_lock_irqsave for improving

performance;

quoted

A race condition which is raised when use both of talitos and dmaengine

to

quoted

offload xor is because napi scheduler will sync all pending requests in

dma

quoted

channels, it will affect the process of raid operations. The descriptor

is

quoted

freed which is submitted just now, but async_tx must check whether this

depend

quoted

tx descriptor is acked, there are poison contents in the invalid

address,

quoted

then BUG_ON() is thrown, so this descriptor will be freed in the next

time.

quoted

Cc: Dan Williams <redacted>
Cc: Vinod Koul <redacted>
Cc: Li Yang <redacted>
Signed-off-by: Qiang Liu <redacted>
---

From the description this sounds like 3 or 4 patches.  Can you split it
up?

I will split this patch according to my description and resend again. Thanks.