[PATCH 1/2] mv_dma: fix mv_init_engine() error case
From: Simon Baatz <hidden>
Date: 2012-06-16 00:21:00
Subsystem:
crypto api, the rest · Maintainers:
Herbert Xu, "David S. Miller", Linus Torvalds
Fix wrongly placed free_irq in mv_init_engine() error recovery. In fact, we can remove the respective label, since request_irq() is the last thing the function does anyway. Signed-off-by: Simon Baatz <redacted> --- drivers/crypto/mv_dma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/mv_dma.c b/drivers/crypto/mv_dma.c
index b84ff80..125dfee 100644
--- a/drivers/crypto/mv_dma.c
+++ b/drivers/crypto/mv_dma.c@@ -296,7 +296,7 @@ static int mv_init_engine(struct platform_device *pdev, if (init_dma_desclist(&tpg.desclist, tpg.dev, sizeof(struct mv_dma_desc), MV_DMA_ALIGN, 0)) { rc = -ENOMEM; - goto out_free_irq; + goto out_unmap_reg; } if (set_dma_desclist_size(&tpg.desclist, MV_DMA_INIT_POOLSIZE)) { rc = -ENOMEM;
@@ -330,8 +330,6 @@ out_free_all: platform_set_drvdata(pdev, NULL); out_free_desclist: fini_dma_desclist(&tpg.desclist); -out_free_irq: - free_irq(tpg.irq, &tpg); out_unmap_reg: iounmap(tpg.reg); tpg.dev = NULL;
--
1.7.9.5