Re: [PATCH 1/2] mach-ux500: Crypto: core support for CRYP/HASH module.

On Wednesday 09 May 2012, Andreas WESTIN wrote:

On 2012-05-09 10:36, Linus Walleij wrote:

quoted

quoted

This needs an explanation! Why do you export an internal data structure
to non-GPL modules?

This does not look like it's needed at all, none of the other two patches use
it. Andreas can you just drop this hunk of the patch?

It is needed if you compile the drivers as modules, but it should be a 
GPL export. I will change it.

How about using distinct identification strings for each version of the
crypto hardware? The driver should really only care about what kind
of device it is talking to, not which SoC it is built into.

	Arnd