Re: [PATCH 14/14] crc32: Select an algorithm via kconfig
flat view
From: Darrick J. Wong <hidden>
Date: 2011-12-03 02:36:46
Also in:
linux-ext4, linux-fsdevel, lkml
On Fri, Dec 02, 2011 at 08:25:05AM +0800, Herbert Xu wrote:
On Thu, Dec 01, 2011 at 12:15:17PM -0800, Darrick J. Wong wrote:quoted
Allow the kernel builder to choose a crc32* algorithm for the kernel. Signed-off-by: Darrick J. Wong <redacted>I don't like this at all. How do you expect distros or indeed anyone to make this choice? For generic C implementations like this we should only have one, and not many.
Slice-by-8 should be picked automatically if the builder doesn't explicitly pick another one. The other choices are provided for people who want a slimmer cache footprint. I guess I could make the Kconfig file a bit more explicit about slice-by-8 being default, or I guess we could just ignore this one patch and thereby keeping us with the old method where anyone who wants the slimmer implementations patches the #defines. --D
Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html