Re: [PATCH] crypto: caam - fix operator precedence in shared descriptor allocation

On Wed, Jun 29, 2011 at 11:12:26AM -0500, Kim Phillips wrote:

On Thu, 26 May 2011 13:30:44 +1000
Herbert Xu [off-list ref] wrote:

quoted

On Mon, May 23, 2011 at 06:45:23PM -0500, Kim Phillips wrote:

quoted

setkey allocates 16 bytes (CAAM_CMD_SZ *
DESC_AEAD_SHARED_TEXT_LEN) shy of what is needed to
store the shared descriptor, resulting in memory
corruption.  Fix this.

Signed-off-by: Kim Phillips <redacted>

Applied to cryptodev.  Thanks Kim!

Herbert, this patch fixes a memory corruption bug introduced in
commit 4427b1b - "crypto: caam - add support for sha512 variants of
existing AEAD algorithms", which is currently the last commit for
caam in Linus' tree. Can you please push this commit (c5bf900 in
cryptodev) to Linus before he releases 3.0?

Thanks for the note.  I'll push this patch to crypto-2.6 and rebase
cryptodev.

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt