Thread (3 messages) read the whole thread 3 messages, 3 authors, 2011-03-23
STALE5610d

[patch] crypto: caam - dereferencing ERR_PTR on allocation failure

From: Dan Carpenter <hidden>
Date: 2011-03-15 06:58:06
Also in: kernel-janitors
Subsystem: crypto api, freescale caam (cryptographic acceleration and assurance module) driver, the rest · Maintainers: Herbert Xu, "David S. Miller", Horia Geantă, Pankaj Gupta, Gaurav Jain, Linus Torvalds

t_alg is an ERR_PTR here so we can't dereference it.

Signed-off-by: Dan Carpenter <redacted>
---
This doesn't compile for me.  Sorry.
diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg.c
index d7fe3d3..a27b6d3 100644
--- a/drivers/crypto/caam/caamalg.c
+++ b/drivers/crypto/caam/caamalg.c
@@ -1136,7 +1136,7 @@ static int __init caam_algapi_init(void)
 		if (IS_ERR(t_alg)) {
 			err = PTR_ERR(t_alg);
 			dev_warn(ctrldev, "%s alg allocation failed\n",
-				 t_alg->crypto_alg.cra_driver_name);
+				 driver_algs[i].driver_name);
 			continue;
 		}
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help