Re: hash finup() issue
flat view
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2011-01-26 23:32:22
On Wed, Jan 26, 2011 at 09:47:27AM +0200, Dmitry Kasatkin wrote:
I am not talking about user space API at all. I talk about kernel crypto API and kernel clients. Please understand the following: when update() is called driver does not know if it is last update or not... That is essential. If client code would always use update/finup then it is fine.. But original API and clients uses update/final... That is why some way (flag) needed to tell if finup() will be used or not... It gave up 20% performance improvement in some case because no extra memcpy has been done... If you think about other solution, please share...
If the crypto user can set the FINUP flag then it can just call finup, simple. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt