Re: [PATCH 0/4] Switch remaining algorithms to shash

On Thu, Dec 04, 2008 at 08:55:57AM +0100, Adrian-Ken Rueegsegger wrote:

If I read the code correctly l and r are not read-only, e.g. in
michael_update there are multiple assignments to mctx->l and mctx->r.
That's the reason why I left them in the desc context.

I see.  In that case your patch is correct.

This also means that the original michael_mic semantics broke
the crypto API requirement that setkey be persistent across the
life-time of an tfm (at least until the next setkey).  Luckily
it seems that the michael_mic users always perform a setkey
prior to each operation so this is OK.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt