Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API.

* David Woodhouse | 2008-08-04 11:12:05 [+0100]:

On Mon, 2008-08-04 at 05:35 -0400, Austin Zhang wrote:

quoted

+u32 __pure crc32c_intel_le_hw(u32 crc, unsigned char const *p, size_t
len)
+{
+       unsigned int iquotient = len / SCALE_F;
+       unsigned int iremainder = len % SCALE_F;
+#ifdef CONFIG_X86_64
+       u64 *ptmp = (u64 *)p;
+#else
+       u32 *ptmp = (u32 *)p;
+#endif

You could perhaps just use 'unsigned long' here, to avoid the ifdef.

And it would be nice if we could make libcrc32c use this too, rather
than just the 'crypto' users.

I'm not sure if I remeber correctly but I thing Herbert was planning to
convert all users over to the crypto API to avoid compile time
dependency.

Sebastian