On Thu, Oct 04, 2007 at 09:37:39AM +0200, Sebastian Siewior wrote:

Loading the crypto algorithm by the alias instead of by module directly
has the advantage that all possible implementations of this algorithm
are loaded automatically and the crypto API can choose the best one
depending on its priority.
Additionally it ensures that the generic implementation as well as the
HW driver (if available) is loaded in case the HW driver needs the
generic version as fallback in corner cases.

Signed-off-by: Sebastian Siewior <redacted>

This patch is correct per se but it combined with the code in
padlock-sha can cause a dead-lock.  Padlock-sha tries to load
the generic sha module in its init function.  At this point it
is still holding the module_mutex so the probe will dead-lock.

The probe is actually pointless since we can always probe when
the algorithm is actually used which does not lead to dead-locks
like this.

So please delete the padlock_sha_check_fallbacks code in your
patch to make it load correctly.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt