Cedric Xing wrote:
quoted hunk ↗ jump to hunk
@@ -339,6 +485,7 @@ module_init(tdx_guest_init);
static void __exit tdx_guest_exit(void)
{
+ tdx_mr_deinit(tdx_attr_groups[0]);
tsm_unregister(&tdx_tsm_ops);
free_quote_buf(quote_data);
misc_deregister(&tdx_misc_dev);
One thing I noticed when merging this series for linux-next is that the
exit release order is broken. tdx_mr_deinit cannot be called while the
attributes are still live. The order needs to be:
tsm_unregister(&tdx_tsm_ops);
free_quote_buf(quote_data);
misc_deregister(&tdx_misc_dev);
tdx_mr_deinit(tdx_attr_groups[0]);
...I will send an incremental patch to fix this up.