Re: [PATCHv13 5/9] efi: Add unaccepted memory support

From
Kirill A. Shutemov <hidden>
Date
2023-06-05 21:37:55
Also in
linux-efi, lkml
Reply to
Borislav Petkov, 2023-06-05
On Mon, Jun 05, 2023 at 09:12:25PM +0200, Borislav Petkov wrote:
On Mon, Jun 05, 2023 at 08:33:03PM +0300, Kirill A. Shutemov wrote:
quoted
There's nothing to warn about. The range (or part of it) is not
represented in the bitmap because it is not unaccepted.
Sorry but how am I supposed to know that?!

I've read the whole patchset up until now and all text talks like *all*
*memory* needs to be accepted and before that has happeend, it is
unaccepted.

So how about you explain that explicitly somewhere, perhaps in a comment
above accept_memory(), that the unaccepted range is not the whole memory
but only, well, what is unaccepted and the rest is implicitly accepted?
Okay, will do.
And I went and looked at the final result - we error() if we fail
accepting.

I guess that's the only action we can do anyway...
Right, there's no recovery from the error.

-- 
  Kiryl Shutsemau / Kirill A. Shutemov
Thread (31 messages) 31 messages, 6 authors, last reply 2023-06-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help