Thread (305 messages) 305 messages, 22 authors, 2023-01-05

RE: [PATCH Part2 v6 06/49] x86/sev: Add helper functions for RMPUPDATE and PSMASH instruction

From: "Kalra, Ashish" <Ashish.Kalra@amd.com>
Date: 2022-08-01 23:32:33
Also in: kvm, linux-crypto, linux-mm, lkml

[AMD Official Use Only - General]

Hello Boris,
quoted
Yes, I will be adding a check for CPU family/model as following :
Why if the PPR is already kinda spelling the already architectural pieces of the RMP entry?
"In order to assist software" it says.
The PPR specifies select portions of the RMP entry format for a specific core/platform. 

Therefore, the complete struct rmpentry definition is non-architectural. 

As per PPR, software should not rely on any field definitions not specified 
in this table and the format of an RMP entry may change in future processors.
So you call the specified ones by their name and the rest is __rsvd.
No need for model checks at all.
Right?
But we can't use this struct on a core/platform which has a different layout, so aren't
the model checks required ?

Thanks,
Ashish
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help