Re: [PATCH v7 43/45] virt: Add SEV-SNP guest driver
From: Randy Dunlap <hidden>
Date: 2021-11-10 22:27:58
Also in:
kvm, linux-efi, linux-mm, lkml, platform-driver-x86
Hi, On 11/10/21 2:07 PM, Brijesh Singh wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/virt/coco/sevguest/Kconfig b/drivers/virt/coco/sevguest/Kconfig new file mode 100644 index 000000000000..96190919cca8 --- /dev/null +++ b/drivers/virt/coco/sevguest/Kconfig@@ -0,0 +1,9 @@ +config SEV_GUEST + tristate "AMD SEV Guest driver" + default y
For this to remain as "default y", you need to justify it. E.g., if a board cannot boot with an interrupt controller, the driver for the interrupt controller can be "default y". So why is this default y? No other drivers in drivers/virt/ are default y.
+ depends on AMD_MEM_ENCRYPT && CRYPTO_AEAD2 + help + The driver can be used by the SEV-SNP guest to communicate with the PSP to + request the attestation report and more. + + If you choose 'M' here, this module will be called sevguest.
thanks. -- ~Randy