Re: [PATCH v6 09/42] x86/sev: Check SEV-SNP features support
From: Borislav Petkov <bp@alien8.de>
Date: 2021-10-19 14:47:47
Also in:
kvm, linux-efi, linux-mm, lkml, platform-driver-x86
On Fri, Oct 08, 2021 at 01:04:20PM -0500, Brijesh Singh wrote:
+static bool do_early_sev_setup(void)
{
if (!sev_es_negotiate_protocol())
sev_es_terminate(SEV_TERM_SET_GEN, GHCB_SEV_ES_PROT_UNSUPPORTED);
+ /*
+ * If SEV-SNP is enabled, then check if the hypervisor supports the SEV-SNP
+ * features.
This and the other comment should say something along the lines of:
"SNP is supported in v2 of the GHCB spec which mandates support for HV
features."
because it wasn't clear to me why we're enforcing that support here.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette