Re: [PATCH Part2 v5 08/45] x86/fault: Add support to handle the RMP fault for user address

From
Dave Hansen <hidden>
Date
2021-08-23 14:20:49
Also in
kvm, linux-crypto, linux-mm, lkml
Reply to
Brijesh Singh, 2021-08-20
On 8/20/21 8:58 AM, Brijesh Singh wrote:
quoted hunk ↗ jump to hunk
+static int handle_split_page_fault(struct vm_fault *vmf)
+{
+	if (!IS_ENABLED(CONFIG_AMD_MEM_ENCRYPT))
+		return VM_FAULT_SIGBUS;
+
+	__split_huge_pmd(vmf->vma, vmf->pmd, vmf->address, false, NULL);
+	return 0;
+}
We had a whole conversation the last time this was posted about huge
page types *other* than THP.  I don't see any comprehension of those
types or what would happen if one of those was used with SEV-SNP.

What was the result of those review comments?

I'm still worried that hugetlbfs (and others) are not properly handled
by this series.
Thread (239 messages) 239 messages, 19 authors, last reply 2022-09-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help