Re: [PATCH v3] Kconfig: fix typos in core makefiles/code and purge remaining ghosts (v3)

From
sashiko-bot@kernel.org
Date
2026-09-05 00:14:40
Also in
linux-input, linux-pci
Reply to
Breno Rodrigues Alves, 2026-09-05
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] The patch completely fails to include the changes described in the commit message. The intended C, Makefile, and Kconfig changes were not staged.
- [Low] The deletion of `lcd-panel-cgram.rst` leaves dangling file references in the MAINTAINERS file and translation indexes, which will break maintainer scripts and documentation builds.
- [Low] The deleted documentation file describes features for an active driver and should not have been removed as 'ghost weight'.
--

commit ffbb32c7781c62294c55f80e85430c46b71f5e34
Author: Breno Rodrigues Alves [off-list ref]

Kconfig: fix typos in core makefiles/code and purge remaining ghosts (v3)

This patch intends to correct various typos in Makefiles and C code, clean up
Kconfig files, and remove remaining ghost weight. It modifies the admin-guide
index and removes the lcd-panel-cgram documentation.
    This patch:
      - Fixes MediaTek interconnect typo mapping mt8196.o to MT8195.
      - Fixes MediaTek regulator typo mapping mt6316-regulator to MT6315.
      - Fixes missing CONFIG_ prefix on DVB_ULE_DEBUG macro in dvb_net.c.
      - Retains critical PCI_IMX6_EP and Tegra audio prompts to keep hidden
        symbols selectable.
      - Cleans up the dangling comment in drivers/leds/Kconfig.
      - Purges the remaining verified ghost weight.
[Severity: Medium]
Did the actual code changes get omitted from this patch? 

The diff only touches documentation files (index.rst and lcd-panel-cgram.rst),
and none of the mentioned Makefile, C, or Kconfig modifications are present
in the staged changes.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/admin-guide/lcd-panel-cgram.rst b/Documentation/admin-guide/lcd-panel-cgram.rst
deleted file mode 100644
index a3eb00c62f532..0000000000000
--- a/Documentation/admin-guide/lcd-panel-cgram.rst
+++ /dev/null
@@ -1,27 +0,0 @@
-======================================
-Parallel port LCD/Keypad Panel support
-======================================
[Severity: Low]
Does this file describe features for an active driver rather than ghost
weight? 

The documentation appears to describe the active parallel LCD and keypad panel
driver located in drivers/auxdisplay/panel.c. 

Should this documentation be retained?

[Severity: Low]
Does removing this documentation leave dangling references elsewhere in the
tree? 

The MAINTAINERS file still lists this file under the PARALLEL LCD/KEYPAD
PANEL DRIVER section, which will cause maintainer script failures.

Additionally, there are still references to lcd-panel-cgram in the translation
indexes under Documentation/translations/zh_CN/admin-guide/index.rst and
Documentation/translations/zh_TW/admin-guide/index.rst.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260905000655.103429-1-breno3011alves@gmail.com?part=1
Thread (2 messages) 2 messages, 2 authors, last reply 2026-09-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help